Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Disable import/no-unassigned-imports ⚙️ #244

Merged
merged 1 commit into from Sep 13, 2020
Merged

Update: Disable import/no-unassigned-imports ⚙️ #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/__snapshots__/index.spec.js.snap
View file
Open in desktop
Expand Up @@ -318,7 +318,7 @@ Object {
"import/no-relative-parent-imports": "off",
"import/no-restricted-paths": "off",
"import/no-self-import": "error",
"import/no-unassigned-import": "error",
"import/no-unassigned-import": "off",
"import/no-unresolved": Array [
"error",
Object {
Expand Down Expand Up @@ -1374,7 +1374,7 @@ Object {
"import/no-relative-parent-imports": "off",
"import/no-restricted-paths": "off",
"import/no-self-import": "error",
"import/no-unassigned-import": "error",
"import/no-unassigned-import": "off",
"import/no-unresolved": Array [
"error",
Object {
Expand Down
6 changes: 3 additions & 3 deletions src/rules/plugin-import.js
View file
Open in desktop
Expand Up @@ -180,9 +180,9 @@ module.exports = {
// configure a useful number.
'import/max-dependencies': 'off',

// Prevents unassigned imports, this should be disabled as necessary in a codebase with
// an explanation of the side effect caused by the import
'import/no-unassigned-import': 'error',
// Allow unassigned imports, it's surprisingly irritating to have to allow
// each occurence
'import/no-unassigned-import': 'off',

// Prevent importing the default as if it were named
'import/no-named-default': 'error',
Expand Down