Add support for reaching receive #722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,10 @@ import Echidna.Types.Signature | |||
|
|
|||
| -- | Fallback function is the null string | |||
| fallback :: SolSignature | |||
| fallback = ("",[]) | |||
| fallback = ("*fallback*",[]) | |||
There was a problem hiding this comment.
fallback functions can have parameters (i.e calldata), the receive function on the other hand is executed only when calldata is empty, so I'm not sure if this will fix all cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should a fix for #714, however, it still need some additional code to make sure fallback and receive are not called often, since 99% of the time, they are not useful and will waste time.