Memory: Show all printable ASCII in hexdump #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only characters in the "word" class were shown in the memory hexdump. These are like alphabetic and numeric characters. Other printable characters like spaces and punctuation were replaced with a ".". This commits shows all printable ASCII characters, and only does the "." replacement for control characters and 127.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only characters in the "word" class were shown in the memory hexdump. These are like alphabetic and numeric characters. Other printable characters like spaces and punctuation were replaced with a ".".
This commits shows all printable ASCII characters, and only does the "." replacement for control characters and 127.
CHANGELOG.md, or an entry is not needed for this changeI don't know if it's needed. I'm happy to provide one if requested.
Summary of changes
Test plan
It hasn't been extensively tested, but the result looked good to me, including when the dump contained stuff that might have been HTML. You can verify the behavior yourself by opening the memory section and looking at the memory of any running program.