Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support volumeGroup as source #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support volumeGroup as source #302

wants to merge 1 commit into from

Conversation

matancarmeli7
Copy link
Contributor

Add Support to volumeGroup as a source, by adding replicationSource object which is replacing volumeID and can handle volumeID or VolumeGroupID as a source.

Signed-off-by: matancarmeli7 matan.carmeli7@gmail.com

@matancarmeli7 matancarmeli7 mentioned this pull request Feb 9, 2023
Closed
@mergify mergify bot added the vendor Pull requests that update vendored dependencies label Feb 9, 2023
@nixpanic
Copy link
Collaborator

This PR adds a dependency on functionalities from the IBM Volume Group Controller. I do not think that is what we want in this project. We need to be storage provider agnostic, and only consume the protocol from the CSI-Addons Spec and use the standard Kubernetes API. If there is a dependency on a storage provider, other storage providers will have difficulties in implementing the required functionality.

Would it be possible to use the upcoming VolumeGroupSnapshot KEP-3476 for this? Or maybe something that works in a similar way, which could be added to the CSI-Addons Spec?

Ideally the features that are available in CSI-Addons will get proposed for the CSI Spec in the future.

@matancarmeli7 matancarmeli7 force-pushed the support_volume_group_as_source branch 5 times, most recently from 834196a to f9089fe Compare June 12, 2023 13:16
@nixpanic
Copy link
Collaborator

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Jun 13, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the support_volume_group_as_source branch from f9089fe to 91772b5 Compare June 13, 2023 08:06
nixpanic
nixpanic reviewed Jun 13, 2023
View reviewed changes
go.mod Outdated
@@ -17,7 +18,7 @@ require (
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
google.golang.org/protobuf v1.30.0
k8s.io/api v0.26.3
k8s.io/apimachinery v0.26.3
k8s.io/apimachinery v0.27.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator-sdk does not like this update. Can you prevent this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I saw, we need to downgrade it first in vg repo, I will do it and will update here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@matancarmeli7
Support volumeGroup as source
6dae44d 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7 matancarmeli7 force-pushed the support_volume_group_as_source branch from 727f51b to 6dae44d Compare June 13, 2023 11:37
@mergify mergify bot requested a review from riya-singhal31 July 13, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erantzabari erantzabari erantzabari approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

@yati1998 yati1998 Awaiting requested review from yati1998

@Yuggupta27 Yuggupta27 Awaiting requested review from Yuggupta27

@riya-singhal31 riya-singhal31 Awaiting requested review from riya-singhal31

@iPraveenParihar iPraveenParihar Awaiting requested review from iPraveenParihar

@karthik-us karthik-us Awaiting requested review from karthik-us

@nixpanic nixpanic Awaiting requested review from nixpanic

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
vendor Pull requests that update vendored dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matancarmeli7 @nixpanic @erantzabari