Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: redirect subsequent imports of "source-map-support" to this… #23

Merged
merged 12 commits into from Oct 6, 2021
Merged

refactor: redirect subsequent imports of "source-map-support" to this… #23

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ce6eafe
refactor: redirect subsequent imports of "source-map-support" to this…
ejose19 Aug 28, 2021
48d7b0a
refactor: change implementation to hook on Module._resolveFilename
ejose19 Aug 28, 2021
1ebbd86
refactor: list explicit arguments
ejose19 Aug 29, 2021
eb81879
refactor: return full resolved path for this package proxy
ejose19 Aug 29, 2021
44c3bce
Several changes:
cspotcode Oct 4, 2021
94e5587
Merge remote-tracking branch 'origin/master' into ej/sourceMapSupport…
cspotcode Oct 4, 2021
e865d19
Correct types; add tests
cspotcode Oct 4, 2021
8ab8b7a
Merge remote-tracking branch 'origin/master' into ej/sourceMapSupport…
cspotcode Oct 4, 2021
f5db819
refactor: adjust install & uninstall to use sharedData
ejose19 Oct 4, 2021
226b96a
refactor: add `onConflictingLibraryRedirect` array to notify all `ins…
ejose19 Oct 4, 2021
a0fdd9b
refactor: only apply redirect if the hook is enabled
ejose19 Oct 5, 2021
a4e1648
ensure disabled hook fn remains disabled when subsequent hook is inst…
cspotcode Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 13 additions & 2 deletions source-map-support.js
View file
Open in desktop
Expand Up @@ -555,6 +555,19 @@ exports.install = function(options) {
}
}

// Use dynamicRequire to avoid including in browser bundles
var Module = dynamicRequire(module, 'module');

// Redirect subsequent imports of "source-map-support"
// to this package
const originalResolveFilename = Module._resolveFilename;
Module._resolveFilename = function resolveFilenameProxy(request, parent, isMain, options) {
if (request === 'source-map-support') {
request = '@cspotcode/source-map-support';
ejose19 marked this conversation as resolved.
Show resolved Hide resolved
}
return originalResolveFilename.call(this, request, parent, isMain, options);
}

// Allow sources to be found by methods other than reading the files
// directly from disk.
if (options.retrieveFile) {
Expand All @@ -577,8 +590,6 @@ exports.install = function(options) {

// Support runtime transpilers that include inline source maps
if (options.hookRequire && !isInBrowser()) {
// Use dynamicRequire to avoid including in browser bundles
var Module = dynamicRequire(module, 'module');
var $compile = Module.prototype._compile;

if (!$compile.__sourceMapSupport) {
Expand Down