preserve-symlinks: default to false #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sullenor
reviewed
Sep 4, 2017
| }); | ||
|
|
||
| const PRESERVE_SYMLINKS = !!argv['preserve-symlinks'] || | ||
| process.env.NODE_PRESERVE_SYMLINKS + '' === '1'; |
There was a problem hiding this comment.
I usually vote for explicit coercions, cause it's easier to figure out what was the initial intention. So would like to suggest to use here smthing like this:
const PRESERVE_SYMLINKS = Boolean(argv['preserve-symlinks']) ||
String(process.env.NODE_PRESERVE_SYMLINKS) === '1';There was a problem hiding this comment.
And looks like that minimist has already done necessary typecasting here :)
| @@ -91,6 +98,8 @@ function resolveAsFile(filepath, extensions = []) { | |||
| } | |||
|
|
|||
| function resolveModule(filepath, {cwd, resolve: resolvecfg = {}}) { | |||
| const preserveSymlinks = resolvecfg.preserveSymlinks !== undefined | |||
| ? !!resolvecfg.preserveSymlinks : PRESERVE_SYMLINKS; | |||
There was a problem hiding this comment.
Just thought that it would be nice to move all the necessary coercions of options (and checking) to the plugin initialisation, so we can keep it at one place. But it doesn't look as an issue at the current step :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate consistent paths for imported files, defaults to nodejs behaviour.
consistency important: f.ex. postcss-icss-selectors :local hashes are based on filenames. browserify defaults to
false(like nodejs), hence resolved filenames would be different between browserify plugins andpostcss-modules-resolve-imports.more info: browserify/browserify#1742 nodejs/node#3402