fix #1402 , fix #1216 (#1403)

Co-authored-by: Ludovico Fischer <43557+ludofischer@users.noreply.github.com>
cssnano · May 29, 2022 · f6c29fb · f6c29fb
1 parent 4dc2fc5
commit f6c29fb
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 10 deletions.
diff --git a/packages/postcss-minify-selectors/src/index.js b/packages/postcss-minify-selectors/src/index.js
@@ -131,17 +131,18 @@ function pseudo(selector) {
     return;
   }
 
-  const uniques = new Set();
-
   selector.walk((child) => {
-    if (child.type === 'selector') {
-      const childStr = String(child);
-
-      if (!uniques.has(childStr)) {
-        uniques.add(childStr);
-      } else {
-        child.remove();
-      }
+    if (child.type === 'selector' && child.parent) {
+      const uniques = new Set();
+      child.parent.each((sibling) => {
+        const siblingStr = String(sibling);
+
+        if (!uniques.has(siblingStr)) {
+          uniques.add(siblingStr);
+        } else {
+          sibling.remove();
+        }
+      });
     }
   });
 

diff --git a/packages/postcss-minify-selectors/test/index.js b/packages/postcss-minify-selectors/test/index.js
@@ -540,4 +540,12 @@ test(
   'should handle attribute selector and namespace #3',
   passthroughCSS('div[att] {  }')
 );
+test(
+  'should not remove equal selectors parts which aren\'t duplicates #1402',
+  processCSS(':where(a,:not(a)) {  }', ':where(a,:not(a)) {  }')
+);
+test(
+  'should not remove equal selectors parts which aren\'t duplicates #1216',
+  processCSS(':where(:nth-child(7),:nth-child(7)~*) {  }', ':where(:nth-child(7),:nth-child(7)~*) {  }')
+);
 test.run();