Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media query extra space #324

Open
tomhodgins opened this issue Dec 16, 2016 · 4 comments · May be fixed by #640
Open

media query extra space #324

tomhodgins opened this issue Dec 16, 2016 · 4 comments · May be fixed by #640
Labels
enhancement help wanted question
Milestone
backlog

Comments

@tomhodgins
Copy link 

@media (min-width: 1px) {
  :root {
    background: lime;
  }
}

correct minification

@media(min-width:1px){:root{background:lime}}
  • whitespace not required after @media unless followd by a word like screen, etc.

CSSnano output

@media (min-width:1px){:root{background:lime}}
  • left optional whitespace after @media
@ben-eb
Copy link
Collaborator

ben-eb commented Dec 16, 2016

I'm not sure that we used to do this or not, but this behaviour is consistent with both https://github.com/jakubpawlowicz/clean-css & https://github.com/css/csso, which is to say I believe it is correct. I need tests in all browsers to prove or disprove that theory before I change any behaviour.

@alexander-akait alexander-akait mentioned this issue Oct 3, 2018
Closed
@alexander-akait alexander-akait linked a pull request Oct 18, 2018 that will close this issue
Open
@alexander-akait alexander-akait added this to the 4.2 milestone Jan 31, 2019
@ludofischer ludofischer modified the milestones: 4.2, backlog Mar 9, 2021
@yisibl
Copy link

yisibl commented Aug 3, 2022 •
edited

@alexander-akait Did you know that Is it safe to remove the spaces after @media in all browsers? How is this handled in SWC?

@alexander-akait
Copy link
Member

@yisibl By spec it is safe, in swc we are removing space

@yisibl
Copy link

yisibl commented Aug 10, 2022

@yisibl By spec it is safe, in swc we are removing space

Nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted question
Projects
None yet
Milestone
backlog
Development

Successfully merging a pull request may close this issue.

feat: remove extra space before media dn suppots at-rules cssnano/cssnano
6 participants
@ludofischer @tomhodgins @ben-eb @andyjansson @yisibl @alexander-akait