Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove extra space before media dn suppots at-rules #640

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: remove extra space before media dn suppots at-rules #640

wants to merge 1 commit into from

Conversation

alexander-akait
Copy link
Member

fixes #324
Also:

  • More tests
  • yarn.lock doesn't contain cssnano-util-get-arguments

@andyjansson
Copy link
Contributor

andyjansson commented Oct 18, 2018 •
edited

Tests look fine. Have we tested so that this change actually works as expected in different browsers? Perhaps we could throw something up on codepen and execute it with browserstack?

PS. Don't forget to update integration tests.

@alexander-akait
Copy link
Member Author

@andyjansson maybe, will be great have simple tests for browserstack. Anyway other minifications for css remove this space and looks in their bug tracker no issue related to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyjansson andyjansson Awaiting requested review from andyjansson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

media query extra space
2 participants
@alexander-akait @andyjansson