Simplify postcss-colormin

[omgovich]

Hey guys!

cssnano already uses colord for color conversions in postcss-colormin and few other packages, but we added 100+ lines around the library to perform the color modification.

Recently I releases colord v2.9 which has built-in color modification utilities so I decided to bring them here and make the cssnano codebase simpler.

The new minifier I implemented inside of colord is also way smarter and performs better compression results.

Example:

SOURCE
rgba(221, 221, 221, 0.5)

current pocstscss-colormin
hsla(0, 0%, 87%, 0.5)

with colord v2.9 (no spaces, no leading zero)
hsla(0,0%,87%,.5)

Don't know how to perform benchmarks here, but it also should work faster.

[omgovich]

Unfortunately, I'm not able to run tests locally (don't know why). Hope you can help me.

cssnano: yarn test

/Users/omgovich/Documents/Dev/cssnano/packages/cssnano-preset-default/src/index.js
  23:29  error  Unable to resolve path to module 'postcss-colormin'  import/no-unresolved

[ludofischer]

Unfortunately, I'm not able to run tests locally (don't know why). Hope you can help me.

From your error message, seems like the ESLint import plugin is failing. What happens if you run yarn test:only?

[omgovich]

yarn test:only works well. Will use this command then. Thx!

[codecov-commenter]

Codecov Report

Merging #1207 (c6373c8) into master (2b5841e) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1207      +/-   ##
==========================================
- Coverage   96.57%   96.54%   -0.04%     
==========================================
  Files         117      115       -2     
  Lines        3646     3613      -33     
  Branches     1071     1062       -9     
==========================================
- Hits         3521     3488      -33     
  Misses        117      117              
  Partials        8        8              

Impacted Files	Coverage Δ
packages/postcss-colormin/src/minifyColor.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b5841e...c6373c8. Read the comment docs.

[omgovich]

The PR is ready. Hope you'll like the update =)

[ludofischer]

Isn't it going to be a burden to handle different browser targets inside colord? What other projects are going to use this minify plugin?

[TrySound]

@ludofischer SVGO

[ludofischer]

SVGO

OK, then I guess you're prepared to handle all sort of issues :-)

[omgovich]

Colord knows nothing about browsers. Its minification utility just works different ways depending on options passed into minify method. And, yeah, I'm preparing it for SVGO as well =)

[TrySound]

I guess browser support can be configured on cssnano side by passing options to minify()

[alexander-akait]

I think we will need colord in rust in near future 😄

[omgovich]

I guess browser support can be configured on cssnano side by passing options to minify()

It already works this way =)

[TrySound]

I think we will need colord in rust in near future 😄

I even know who could do it.