fix(postcss-convert-values): preserve percentage-only properties #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludofischer
commented
Oct 20, 2021
| @@ -18,6 +18,23 @@ const LENGTH_UNITS = [ | |||
| 'pc', | |||
| 'px', | |||
| ]; | |||
|
|
|||
| // These properties only accept percentages, so no point in trying to transform | |||
| const notANumber = new Set([ | |||
There was a problem hiding this comment.
Are there more of these? Could not find a list of CSS properties grouped by accepted values
| @@ -71,7 +88,7 @@ function clampOpacity(node) { | |||
| } | |||
| } | |||
|
|
|||
| function shouldKeepUnit(decl) { | |||
| function shouldKeepZeroUnit(decl) { | |||
There was a problem hiding this comment.
I have changed this function name because it is only used in the parseWord() function when num === 0.
| if ( | ||
| ~lowerCasedProp.indexOf('flex') || | ||
| lowerCasedProp.indexOf('--') === 0 || | ||
| notANumber.has(lowerCasedProp) |
There was a problem hiding this comment.
Skip processing completely here, since there is not meaningful possible conversion.
Don't process properties that look like numbers, but only take percentage values according to the spec. Fix #1203
ludofischer
force-pushed
the
fix-percentages
branch
from
524c382
to
26f5029
Compare
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 96.53% 96.54%
=======================================
Files 116 116
Lines 3611 3614 +3
Branches 1063 1064 +1
=======================================
+ Hits 3486 3489 +3
Misses 117 117
Partials 8 8
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't process properties that look like numbers, but only take percentage values
according to the spec.
Fix #1203
I've found that the original code seems to repeat similar checks in in different places, so I've found the logic a bit confusing, but I have avoided changing too much.