New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postcss-reduce-initial): regenerate data #1242
Conversation
* Extract script out of published `src` directory * Run script to update initial value data from MDN
Codecov Report
@@ Coverage Diff @@
## master #1242 +/- ##
==========================================
- Coverage 96.54% 96.50% -0.05%
==========================================
Files 116 114 -2
Lines 3619 3576 -43
Branches 1064 1051 -13
==========================================
- Hits 3494 3451 -43
Misses 117 117
Partials 8 8
Continue to review full report at Codecov.
|
"text-decoration-color": "currentcolor", | ||
"text-emphasis-color": "currentcolor", | ||
"text-emphasis-position": "over right", | ||
"transform-box": "border-box", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct per spec
@@ -209,9 +226,9 @@ | |||
"right": "auto", | |||
"rotate": "none", | |||
"row-gap": "normal", | |||
"ruby-position": "over", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct per spec
* correct mask-repeat initial value from no-repeat to repeat and move to fromInitial since repeat.length = 6 < initial.length = 7 * add transform-box to default ignore list
@@ -21,7 +21,6 @@ | |||
"mask-clip": "border-box", | |||
"mask-mode": "match-source", | |||
"mask-origin": "border-box", | |||
"mask-repeat": "no-repeat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the previous fix for this was incorrect because if you change mask-repeat
to repeat
then you also need to move it to fromInitial
since now the value is shorter than initial
.
@ludofischer Please submit invoice on 120$ https://opencollective.com/cssnano Regarding to this PR looks good, we can fix it if somebody reported about problem, it is fast and easy |
src
directoryThe
script
directory does not need to be published so it's better to move it out ofsrc
as inpostcss-ordered-values
. This also makes thebuild
script more resistant to using a different command line interpreter, as theignore
expression is simpler (it previously failed on windows withoutcross-env
). To test everything still works I've re-run the script to update the initial values.