Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-reduce-initial): regenerate data #1242

Merged
merged 2 commits into from Nov 26, 2021
Merged

Conversation

ludofischer
Copy link
Collaborator

  • Extract script out of published src directory
  • Run script to update initial value data from MDN

The script directory does not need to be published so it's better to move it out of src as in postcss-ordered-values. This also makes the build script more resistant to using a different command line interpreter, as the ignore expression is simpler (it previously failed on windows without cross-env). To test everything still works I've re-run the script to update the initial values.

* Extract script out of published `src` directory
* Run script to update initial value data from MDN
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #1242 (f169a38) into master (9ecc907) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
- Coverage   96.54%   96.50%   -0.05%     
==========================================
  Files         116      114       -2     
  Lines        3619     3576      -43     
  Branches     1064     1051      -13     
==========================================
- Hits         3494     3451      -43     
  Misses        117      117              
  Partials        8        8              
Impacted Files Coverage Δ
packages/postcss-reduce-initial/src/index.js 100.00% <100.00%> (ø)
packages/postcss-reduce-initial/script/lib/io.mjs
.../postcss-reduce-initial/script/lib/mdnCssProps.mjs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecc907...f169a38. Read the comment docs.

"text-decoration-color": "currentcolor",
"text-emphasis-color": "currentcolor",
"text-emphasis-position": "over right",
"transform-box": "border-box",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct per spec

@@ -209,9 +226,9 @@
"right": "auto",
"rotate": "none",
"row-gap": "normal",
"ruby-position": "over",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct per spec

* correct mask-repeat initial value from no-repeat to repeat and move
  to fromInitial since repeat.length = 6 < initial.length = 7
* add transform-box to default ignore list
@@ -21,7 +21,6 @@
"mask-clip": "border-box",
"mask-mode": "match-source",
"mask-origin": "border-box",
"mask-repeat": "no-repeat",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the previous fix for this was incorrect because if you change mask-repeat to repeat then you also need to move it to fromInitial since now the value is shorter than initial.

@alexander-akait
Copy link
Member

@ludofischer Please submit invoice on 120$ https://opencollective.com/cssnano

Regarding to this PR looks good, we can fix it if somebody reported about problem, it is fast and easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants