chore(postcss-normalize-url): inline is-absolute-url dep #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is-absolute-url has become ESM only. It boils down to two short regexes, so we can inline it. The license is MIT which is the same as cssnano.
ludofischer
commented
Nov 30, 2021
|
|
||
| const multiline = /\\[\r\n]/; | ||
| // eslint-disable-next-line no-useless-escape | ||
| const escapeChars = /([\s\(\)"'])/g; | ||
|
|
||
| // Scheme: https://tools.ietf.org/html/rfc3986#section-3.1 | ||
| // Absolute URL: https://tools.ietf.org/html/rfc3986#section-4.3 | ||
| const ABSOLUTE_URL_REGEX = /^[a-zA-Z][a-zA-Z\d+\-.]*?:/; |
There was a problem hiding this comment.
The regexes are simple and I could not see any vulnerabilities reports or significant changes in the last two years.
alexander-akait
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is-absolute-url has become ESM only. It boils down to two
short regexes, so we can inline it.
The license is MIT which is the same as cssnano.