Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pnpm #1269

Merged
merged 2 commits into from Dec 18, 2021
Merged

Pnpm #1269

merged 2 commits into from Dec 18, 2021

Conversation

ludofischer
Copy link
Collaborator

No description provided.

Using is-resolvable as a dep does not work inside pnpm monorepos.
Inlining the code solves the issue.
@codecov-commenter
Copy link

Codecov Report

Merging #1269 (a5a4e6e) into master (277a4d9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   96.83%   96.83%           
=======================================
  Files         125      125           
  Lines        8239     8251   +12     
  Branches       15       15           
=======================================
+ Hits         7978     7990   +12     
  Misses        261      261           
Impacted Files Coverage Δ
packages/cssnano/src/index.js 96.85% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277a4d9...a5a4e6e. Read the comment docs.

@alexander-akait
Copy link
Member

Great improvement

@alexander-akait
Copy link
Member

Our CI is very fast

@ludofischer ludofischer marked this pull request as ready for review December 18, 2021 16:35
@ludofischer ludofischer merged commit 6f9c747 into master Dec 18, 2021
@ludofischer ludofischer deleted the pnpm branch December 18, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants