Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge-rule before longhand in default preset #886

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anikethsaha
Copy link
Member

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         118      118           
  Lines        3452     3452           
  Branches     1036     1036           
=======================================
  Hits         3358     3358           
  Misses         86       86           
  Partials        8        8
Impacted Files Coverage Δ
packages/cssnano-preset-default/src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfcaaf...b4180c2. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests, also we should look what is changes in snapshots

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020

Codecov Report

Merging #886 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #886   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         119      119           
  Lines        3477     3477           
  Branches     1047     1047           
=======================================
  Hits         3382     3382           
  Misses         87       87           
  Partials        8        8           
Impacted Files Coverage Δ
packages/cssnano-preset-default/src/index.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f3423...6ad305c. Read the comment docs.

.process(css, { from: undefined })
.then((result) => {
expect(result.css).toBe(
'.bar,.foo{border-color:#cc1f1a}.bar{border-bottom:1px}'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This output according to the issue #701 (comment) is wrong, not sure why it is wrong in the issue as this is the safe merging in my opinion.

according to the issue, it should be

.foo {
  border-color: #cc1f1a;
}

.bar {
  border-bottom: 1px;
  border-color: #cc1f1a;
}

Though I will check this once again, @evilebottnawi thoughts ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is bug, need to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

mergeRules when combined with mergeLonghand can create the wrong rules
4 participants