New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: merge-rule before longhand in default preset #886
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 118 118
Lines 3452 3452
Branches 1036 1036
=======================================
Hits 3358 3358
Misses 86 86
Partials 8 8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests, also we should look what is changes in snapshots
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 119 119
Lines 3477 3477
Branches 1047 1047
=======================================
Hits 3382 3382
Misses 87 87
Partials 8 8
Continue to review full report at Codecov.
|
.process(css, { from: undefined }) | ||
.then((result) => { | ||
expect(result.css).toBe( | ||
'.bar,.foo{border-color:#cc1f1a}.bar{border-bottom:1px}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output according to the issue #701 (comment) is wrong, not sure why it is wrong in the issue as this is the safe merging in my opinion.
according to the issue, it should be
.foo {
border-color: #cc1f1a;
}
.bar {
border-bottom: 1px;
border-color: #cc1f1a;
}
Though I will check this once again, @evilebottnawi thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is bug, need to fix
fixes #701
#701 (comment)