fix(postcss-merge-longhand): allow mixing custom properties with regular values when merging #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar values when merging
This resolves an issue where merging properties would break the css
Example of the issue
```css
/* This declaration should not be changed */
h1{border:var(--v1) solid var(--v2, #abc123);border-right-color:blue}
/* Before this commit it would be, into this */
h1{border-right-color:var(--v2,#abc123);border-right:var(--v1) solid #00f;border-style:solid;border-width:var(--v1)}
```
|
how about keeping the merge check and remove the whole else block alone here ? cause this would merge non custom props val with custom props val |
When would this cause an issue? I would like to add a test case for this if it does cause any issues, since the current tests all pass with my changes. I admit to being a bit sceptical when removing the check myself, but since it didn't seem to cause any issues and it completely solved my issue it seemed fine. |
|
Maybe, try using CSS where there is a customs value and non-custom value It should not merge them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where merging properties would break the css
Example of the issue