postcss-nesting: make edition 2024-02 the default
#1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/postcss-nesting/README.md
Outdated
| ## Options | ||
|
|
||
| ### edition | ||
|
|
||
| The default behavior is to transpile CSS following an older version of the CSS nesting specification. | ||
| The default behavior is to transpile CSS following the version of the CSS nesting specification as it existed during the last major version of this plugin. |
There was a problem hiding this comment.
I'm not sure this sentence is clear enough.
Is there more recent work to the spec? While I know we don't need to explain the specs I feel it doesn't hurt to be more explicit here.
There was a problem hiding this comment.
I was being vague on purpose but I see know that we need to be clearer on why this is vague.
I didn't want to have to change this sentence each time we ship a new edition or change the default.
Maybe better to explain why we have this mechanic instead.
There was a problem hiding this comment.
@Antonio-Laguna I've rewritten this section which more focus on what it is and when users should set this option. Hopefully an improvement :)
Antonio-Laguna
approved these changes
Apr 20, 2024
…9ed' into postcss-nesting-make-2024-the-default--sympathetic-spadefoot-toad-3bea5e0b0d
romainmenke
merged commit 086320b
into
v10--gregarious-seahorse-86cb98a9ed
6 checks passed
romainmenke
deleted the
postcss-nesting-make-2024-the-default--sympathetic-spadefoot-toad-3bea5e0b0d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024-02the default inpostcss-nesting