make a <number> that is equal to zero is allowed value for <angle> (f…

…ixes #30)
csstree · Dec 21, 2016 · 981fca6 · 981fca6
1 parent d7bb0df
commit 981fca6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/lib/syntax/generic.js b/lib/syntax/generic.js
@@ -97,10 +97,12 @@ function dimension(type) {
     };
 }
 
-function length(node) {
-    return isCalc(node) ||
-           (node.data.type === 'Dimension' && LENGTH.hasOwnProperty(node.data.unit.toLowerCase())) ||
-           (node.data.type === 'Number' && Number(node.data.value) === 0);
+function zeroUnitlessDimension(type) {
+    return function(node) {
+        return isCalc(node) ||
+               (node.data.type === 'Dimension' && type.hasOwnProperty(node.data.unit.toLowerCase())) ||
+               (node.data.type === 'Number' && Number(node.data.value) === 0);
+    };
 }
 
 function attr(node) {
@@ -180,7 +182,7 @@ function customIdent(node) {
 }
 
 module.exports = {
-    'angle': dimension(ANGLE),
+    'angle': zeroUnitlessDimension(ANGLE),
     'attr()': attr,
     'custom-ident': customIdent,
     'decibel': dimension(DECIBEL),
@@ -191,7 +193,7 @@ module.exports = {
     'id-selector': astNode('Hash'), // element( <id-selector> )
     'ident': astNode('Identifier'),
     'integer': integer,
-    'length': length,
+    'length': zeroUnitlessDimension(LENGTH),
     'number': number,
     'number-zero-one': numberZeroOne,
     'number-one-or-greater': numberOneOrGreater,

diff --git a/test/fixture/syntax/generic.json b/test/fixture/syntax/generic.json
@@ -15,7 +15,8 @@
             "1RAD",
             "1turn",
             "1TURN",
-            "calc(2 * 1deg)"
+            "calc(2 * 1deg)",
+            "0"
         ],
         "invalid:Mismatch": [
             "",