Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kick up max_files default 10k → 50k #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ulidtko
Copy link

@ulidtko ulidtko commented Jul 17, 2019

Hi!

I do understand that anyone can let g:ctrlp_max_files = 50000 or whatever in their own vimrc. Many people do change that.

However, I sincerely believe that 10k files is way too low for such an awesome plugin.

You see, it isn't hard to navigate a small repo. The project is already a mess at the point when you reach out for "bigger tools" like CtrlP. Further, when you do pull out those tools, you usually want them to work. Nobody likes unreliable tools.

To substantiate, here I have a Linux kernel tree of a particular version. Cloc says, there're 46715 text files. 46k files. Sure enough, as I went with the defaults, many files I know are there — fail to be found via CtrlP. This undermines my trust in the tool; besides frustrating, I immediately recount the previous occurrences the tool failed on me, and just start wanting ever more to ditch it and find something else.

I bet, too many people will, irrationally or not, go the ditching route — rather than go distract themselves with config reading and option tweaking. Even less so, submitting PRs.

So, well... I know, changing defaults is often met with reluctance. But you have no risk here. Just raise the limit... please. This line hasn't been touched since 2012!

Thanks in advance, and solid gratitude for what you do.

@paulharris
Copy link

I would vote for this, or at least show some warning with guidance that you have hit the limit.
I thought it was a bug when ctrlp couldn't find a file in boost, when I could clearly see it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants