Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flashcache): flash cache in cluster #2944

Closed
wants to merge 24 commits into from
Closed

feat(flashcache): flash cache in cluster #2944

wants to merge 24 commits into from

Conversation

sejust
Copy link
Collaborator

@sejust sejust commented Dec 26, 2023

Fixes: #2943

Main Issue: #2943

Motivation

Sharding cache in distributed memories of cluster servers.

Modifications

  • flash server: distributed memory cache of one server.
  • flash group: cache group stored in master raft.
  • cli: command tools of flash node and flash group.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue)
  • Documentation Update (if none of the other choices apply)
  • So on...

Verifying this change

  • Make sure that the change passes the testing checks.

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Master
  • MetaNode
  • DataNode
  • ObjectNode
  • AuthNode
  • FlashNode
  • Blobstore
  • Client
  • Cli
  • SDK
  • Other Tools
  • Common Packages
  • Dependencies
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Review Expection

  • in-two-days
  • weekly
  • free-time
  • whenever

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for cubefs-check ready!

Name Link
🔨 Latest commit 3a2f5da
🔍 Latest deploy log https://app.netlify.com/sites/cubefs-check/deploys/665043514136790008104aee
😎 Deploy Preview https://deploy-preview-2944--cubefs-check.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: Patch coverage is 40.19720% with 2608 lines in your changes are missing coverage. Please review.

Project coverage is 40.56%. Comparing base (bdffd66) to head (9567c44).
Report is 58 commits behind head on master.

Current head 9567c44 differs from pull request most recent head 3a2f5da

Please upload reports for the commit 3a2f5da to get more accurate results.

Files Patch % Lines
proto/distributed_cache.pb.go 1.25% 1098 Missing ⚠️
cli/cmd/flashgroup.go 0.00% 356 Missing ⚠️
proto/distributed_cache.go 0.00% 158 Missing ⚠️
flashnode/cachengine/engine.go 38.16% 119 Missing and 9 partials ⚠️
cli/cmd/flashnode.go 8.39% 120 Missing ⚠️
master/flash_group.go 74.31% 84 Missing and 28 partials ⚠️
flashnode/cachengine/block.go 46.44% 93 Missing and 5 partials ⚠️
master/flash_node_topology.go 73.60% 52 Missing and 19 partials ⚠️
cli/cmd/vol.go 0.00% 61 Missing ⚠️
master/flash_node.go 79.10% 43 Missing and 18 partials ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2944      +/-   ##
==========================================
+ Coverage   40.49%   40.56%   +0.07%     
==========================================
  Files         603      620      +17     
  Lines      125057   129370    +4313     
==========================================
+ Hits        50643    52485    +1842     
- Misses      70051    72412    +2361     
- Partials     4363     4473     +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejust sejust force-pushed the flash_cache branch 6 times, most recently from 89ed403 to 587b693 Compare January 3, 2024 07:36
@sejust sejust force-pushed the flash_cache branch 13 times, most recently from e303f94 to 57d08ec Compare January 11, 2024 04:46
@sejust sejust marked this pull request as ready for review January 12, 2024 01:42
@sejust sejust force-pushed the flash_cache branch 3 times, most recently from 1019159 to b6648e2 Compare January 19, 2024 06:35
@sejust sejust force-pushed the flash_cache branch 2 times, most recently from c4c8aa5 to 1061e97 Compare January 26, 2024 11:11
sejust added 11 commits May 24, 2024 10:44
. #22200490

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115361

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200531 #22200571 #22200580

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200504 #22200509

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115361

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200518

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115371 of 21940685

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200518

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200580

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115371

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115371

Signed-off-by: slasher <mcq.sejust@gmail.com>
sejust and others added 4 commits May 24, 2024 14:10
. #22200600

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200600

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200600

Signed-off-by: slasher <mcq.sejust@gmail.com>
Signed-off-by: leonrayang <chl696@sina.com>
sejust and others added 6 commits May 24, 2024 15:26
. #22200580

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22200563

Signed-off-by: slasher <mcq.sejust@gmail.com>
. #22115371

Signed-off-by: slasher <mcq.sejust@gmail.com>
Signed-off-by: leonrayang <chl696@sina.com>
Signed-off-by: leonrayang <chl696@sina.com>
@leonrayang leonrayang closed this May 28, 2024
@leonrayang leonrayang deleted the flash_cache branch May 28, 2024 02:27
@sejust sejust restored the flash_cache branch May 28, 2024 02:58
@sejust sejust reopened this May 28, 2024
@sejust sejust closed this May 28, 2024
@sejust sejust deleted the flash_cache branch May 28, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Flash Cache in Cluster
2 participants