-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move find and replace into task queue, send progress updates via websockets #29
Open
cubeghost
wants to merge
43
commits into
main
Choose a base branch
from
workers
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noodled on here https://codepen.io/cubeghost/pen/KKXepGo and here https://codesandbox.io/s/pensive-maria-pqtkxr
one big issue currently is the websocket message queue is keyed to the user session, if a user has multiple tabs of the tag replacer open, the websocket messages end up splitting between them kind of randomly(?). we need to either share the entire app state between tabs (a la service workers) or have unique message queues per "tab session" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems this hopes to solve:
The idea:
TumblrClient
and into workers, allowing for more exact rate limitingfind
to queue thereplace
jobs, instead of runningfind
again like we do nowEarly draft of system diagram
it's close enoughStuff that ended up happening too:
202220232024)