Skip to content

Commit

Permalink
[import-restrictions] Update name of the experimental splitting build.
Browse files Browse the repository at this point in the history
We're waiting on evanw/esbuild#492 to split the build properly. The code I wrote to try to get that working ended up being more practical for enforcing import graph restrictions.
  • Loading branch information
lgarron committed May 6, 2021
1 parent ae8fd47 commit 14684b4
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 11 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@
"build-bundle-global": "npx esbuild --target=es2015 --bundle --format=cjs --minify --outdir=dist/bundle-global src/cubing/cubing.bundle-global.ts",
"build-types": "npx tsc --build tsconfig-types.json",
"build-bin": "npx esbuild --target=es2015 --bundle --external:three --format=esm --outfile=dist/bin/puzzle-geometry-bin.js src/bin/puzzle-geometry-bin.ts",
"build-experimental-splitting-build": "node src/make/build.js",
"build-tsc": "npm run build-types && npx tsc --build ./tsconfig.json",
"generate-js": "npm run generate-js-parsers && npm run generate-js-svg",
"generate-js-parsers": "npx pegjs src/cubing/alg/parser/parser-pegjs.pegjs && npx pegjs src/cubing/kpuzzle/parser/parser-pegjs.pegjs",
"generate-js-svg": "echo \"TODO: Generating JS for SVGs is not implemented yet.\"",
"dev": "npx snowpack dev",
"clean": "rm -rf dist .cache .parcel-cache .rpt2_cache /tmp/cubing-js-parcel",
"test": "npm run test-jest && npm run lint && npm run build-experimental-splitting-build && npm run build-tsc",
"test": "npm run test-jest && npm run lint && npm run test-import-restrictions && npm run build-tsc",
"test-import-restrictions": "node src/import-restrictions/build.js",
"test-jest": "npx jest --collectCoverage",
"test-node-require": "node src/dist-test/require.cjs",
"test-node-import": "node src/dist-test/import.mjs",
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
Some notes:
- Don't allow the same cross-target import to be both direct and dynamic. If there is any direct import, we pay the same performance penalty regardless of any dynamic imports.
- Exception: If you're actively trying to convert all those direct imports to dynamic, it may make sense to commit intermediate progress with both allowed.
- TODO: remove all cyclic imports.
*/
Expand Down
9 changes: 0 additions & 9 deletions src/make/clean.js

This file was deleted.

0 comments on commit 14684b4

Please sign in to comment.