Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that es2020 is required #193

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Specify that es2020 is required #193

merged 6 commits into from
Jul 18, 2022

Conversation

debater-coder
Copy link
Contributor

@debater-coder debater-coder commented Jul 10, 2022

Closes #192

@debater-coder
Copy link
Contributor Author

What I have done is added that if you are using a bundler you must set it to use es2020. I have put this under its own section for clarity. Maybe if we could add more troubleshooting problems like this we could make a FAQ, but because its only one problem the user may encounter, I've put it in its own section.

@lgarron
Copy link
Member

lgarron commented Jul 12, 2022

Thanks!

In general, I'd like to make sure that js.cubing.net is the canonical place for info. https://js.cubing.net/cubing/#javascript already mentions:

If you are having trouble, make sure your tool is compatible with ES2020 syntax. We recommend using esbuild or tools based on esbuild, and you may find this project template a helpful start.

Do you think you could make this a more concise reference in an existing section?

Also, in the past I would have avoided a reference to Vite, but given all the compatibility issues with Parcel it looks like the best "batteries included" bundler for now. I think it would be alright to have a slightly expanded section with Vite as an example, although I'd like to keep it on the website and as concise as possible.

Would you be able to update this, taking all that into account?
(It's alright if not, I can also update it myself when I get around to it.)

@debater-coder
Copy link
Contributor Author

debater-coder commented Jul 12, 2022

Would you be able to update this, taking all that into account?

Yes, I'll update it as soon as possible.

@debater-coder
Copy link
Contributor Author

debater-coder commented Jul 12, 2022

Okay, so now I've moved the section to docs/cubing/index.html, and I've kept the details on Vite as minimal as possible.

@lgarron lgarron force-pushed the main branch 2 times, most recently from 49ba80a to b6a03bf Compare July 16, 2022 23:19
@lgarron
Copy link
Member

lgarron commented Jul 18, 2022

So, I spent some time this week trying to get Vite to have full compatibility with es2020, and did not succeed.

From vitejs/vite#9062 it sounds like we won't work in Vite out of the box until Vite 4 — and Vite 3 is barely released. I wanted to be able to recommend Vite as a bundler in our docs, but I have to give up on that for now, and I'm reluctant to mention them all if we have such reservations. :-/

I'd like to keep thinking about this, apologies for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cubing.js not working with vite
2 participants