Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow upcoming rspec-expectations 4.x to be used #789

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Feb 28, 2021

Summary

Loosen dependency on rspec-expections to allow version 4.x

Motivation and Context

This prepares Aruba for the upcoming RSpec 4.0, and will allow Aruba 1.x to be
used to test that release.

How Has This Been Tested?

This was split off from #787 so has been tested in CI already.

Types of changes

  • New feature (non-breaking change which adds functionality)

@mvz
Copy link
Contributor Author

mvz commented Feb 28, 2021

Current plans for RSpec are to keep the current cucumber + aruba dependencies and only upgrade after the 4.0 release. This means this PR can be on hold until then.

@mvz mvz added the on-hold This issue is waiting for something else to happen first. label Feb 28, 2021
@mvz mvz self-assigned this Feb 28, 2021
@mvz
Copy link
Contributor Author

mvz commented Apr 4, 2021

When RSpec 4 is released, Aruba should be tested with both 3 and 4.

@mvz mvz marked this pull request as draft June 13, 2021 16:50
@mvz mvz removed their assignment Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold This issue is waiting for something else to happen first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants