Skip to content

Commit

Permalink
Allow google-protobuf 3.8, recommend its usage for all rubies aside J…
Browse files Browse the repository at this point in the history
…Ruby
  • Loading branch information
luke-hill committed Jun 3, 2019
1 parent 48aca19 commit 83660e0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cucumber-messages/ruby/Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true
source "https://rubygems.org"

# Use an older protobuf on JRuby and MRI < 2.5
gem 'google-protobuf', '~> 3.2.0.2' if RbConfig::CONFIG['MAJOR'].to_i == 2 && RbConfig::CONFIG['MINOR'].to_i < 5 || RUBY_PLATFORM == 'java'
# Use an older protobuf on JRuby
gem 'google-protobuf', '~> 3.2.0.2' if RUBY_PLATFORM == 'java'

gemspec
4 changes: 2 additions & 2 deletions cucumber-messages/ruby/cucumber-messages.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ Gem::Specification.new do |s|
'source_code_uri' => 'https://github.com/cucumber/cucumber/blob/master/cucumber-messages/ruby',
}

# Users of JRuby and MRI < 2.6 will have to specify google-protobuf=3.2 (later versions don't work)
s.add_dependency('google-protobuf', ['>= 3.2', '<= 3.7'])
# Users of JRuby google-protobuf=3.2 (later versions don't work)
s.add_dependency('google-protobuf', ['>= 3.2', '<= 3.8'])
s.add_development_dependency 'bundler'
s.add_development_dependency 'rake', '~> 12.3'
s.add_development_dependency 'rspec', '~> 3.7'
Expand Down

0 comments on commit 83660e0

Please sign in to comment.