Skip to content

Commit

Permalink
CCK: Add implementation of named hook in ruby (#1984)
Browse files Browse the repository at this point in the history
* Add implementation of named hook in the ruby CCK

* Add link to the PR in the changelog

* Exclude hooks from json-formatter acceptance tests

Named hooks are not supported yet by the version of cucumber-ruby used
in the validation tests of the json-formatter

* Use a version of cucumber which actually supports named hooks. This should remain temporary
  • Loading branch information
aurelien-reeves committed May 18, 2022
1 parent 2598e8b commit cf9e64e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions compatibility-kit/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

* [Ruby] Add implementation for named hooks ([#1984](https://github.com/cucumber/common/pull/1984))

## [9.2.0] - 2022-04-01

### Added
Expand Down
3 changes: 1 addition & 2 deletions compatibility-kit/ruby/features/hooks/hooks.feature.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ def attach_or_embed(world, data, media_type)
# no-op
end

Before do
# This is the equivalent of the new named hook in typescript
Before(name: 'A named hook') do
# no-op
end

Expand Down
2 changes: 1 addition & 1 deletion json-formatter/ruby-testdata/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ source "https://rubygems.org"

git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }

gem "cucumber", "~> 7.1.0"
gem "cucumber", git: 'https://github.com/cucumber/cucumber-ruby.git', branch: 'add-support-for-named-hooks'
gem "json"
gem "rspec"

0 comments on commit cf9e64e

Please sign in to comment.