Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format: add support for gherkin rule/example syntax #1273

Merged
merged 42 commits into from Mar 18, 2020

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 30, 2019

After the move to Gherkin 9 and cucumber-messages, we can execute specs that include Rule/Example syntax, but still need to update the formatter helpers and built-in formatters to handle the results.

@davidjgoss
Copy link
Contributor Author

The happy path for JSON formatter is working, moving on to failure cases and other built-in formatters, a couple of bits I am unsure of (above) which can be circled back to.

@davidjgoss davidjgoss marked this pull request as ready for review January 29, 2020 02:03
@davidjgoss
Copy link
Contributor Author

@charlierudolph this is ready to go now I think.

In the end it was mostly about changing gherkin document helper to be able to handle the rule/example structure when matching up from pickles, and some usage of this in the JSON formatter - beyond that it's just adding/changing tests on the other formatters to confirm they work normally, and adding some acceptance-level coverage as well.

Let me know if you think anything is missing.

@davidjgoss
Copy link
Contributor Author

@charlierudolph this will probably need a rebase after #1286 goes in, but otherwise is it okay?

@davidjgoss davidjgoss added this to the 7.0.0 milestone Feb 14, 2020
@davidjgoss davidjgoss mentioned this pull request Feb 14, 2020
5 tasks
@davidjgoss
Copy link
Contributor Author

@charlierudolph feedback addressed and latest changes from master merged in here

src/formatter/json_formatter.ts Outdated Show resolved Hide resolved
src/formatter/json_formatter.ts Outdated Show resolved Hide resolved
src/formatter/progress_bar_formatter_spec.ts Show resolved Hide resolved
src/formatter/rerun_formatter_spec.ts Show resolved Hide resolved
features/formatters.feature Outdated Show resolved Hide resolved
src/formatter/progress_formatter_spec.ts Outdated Show resolved Hide resolved
@davidjgoss davidjgoss merged commit bf23ac9 into master Mar 18, 2020
@davidjgoss davidjgoss deleted the rule-example-support branch March 18, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants