Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: warn when untested node version #1959

Merged
merged 6 commits into from Mar 25, 2022
Merged

Conversation

davidjgoss
Copy link
Contributor

🤔 What's changed?

Distinguish between supported (error if not met) and tested (warning if not met) Node.js versions.

⚡️ What's your motivation?

See #1958 (comment)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, docuemntation etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@coveralls
Copy link

coveralls commented Mar 21, 2022

Coverage Status

Coverage increased (+0.002%) to 98.221% when pulling 772c7e0 on feat/node-warn-untested into 8e53bab on main.

@davidjgoss davidjgoss enabled auto-merge (squash) March 25, 2022 09:26
@davidjgoss davidjgoss merged commit ba0c700 into main Mar 25, 2022
@davidjgoss davidjgoss deleted the feat/node-warn-untested branch March 25, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants