fix: try require first for custom formatters so transpiled ones work

[davidjgoss]

🤔 What's changed?

Tweak the loading of custom formatters and snippet syntaxes so we try require() first and then try import() if it turns out the target file is a module (ESM).

This mirrors how we are also now loading the configuration file.

⚡️ What's your motivation?

https://cucumberbdd.slack.com/archives/C6QJ6N695/p1649071066867509

An edge case arguably, but some users in the wild have formatters in their project written in TypeScript (or something else that transpiles) and take advantage of the fact that --require-module means their transpiler has registered by the time the formatter is loaded.

This is quite cool and something we should avoid breaking if possible. We broke it with earlier RCs because we switched to exclusively using import() to load custom formatters, which doesn't yet account for just-in-time transpiled code.

In 1 or 2 major releases (when loader hooks are a solved problem) we'll ditch the require() bit and just use import() which will simplify things a lot but for now this works reliably and is well covered by tests.

🏷️ What kind of change is this?

• 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

• I agree to respect and uphold the Cucumber Community Code of Conduct
• I've changed the behaviour of the code
  • I have added/updated tests to cover my changes.
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.
• Users should know about my change
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

---

This text was originally generated from a template, then edited by hand. You can modify the template here.

[coveralls]

Coverage increased (+0.009%) to 98.232% when pulling fdedd7a on fix/custom-formatter-transpile into 901561e on main.

[aurelien-reeves]

Looks nice!

Would it be hard to add a test (maybe a scenario?) that would help to make sure we were able to reproduce the error before the patch, and then validate the patch?

[davidjgoss]

@aurelien-reeves thanks - several test in builder_spec.ts would fail without the code change here. I'll have a look at the feature tests too.

[ludeknovy]

Thanks for the fix ❤️

[aurelien-reeves]

🤩