Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world: extend docs around classes and functions, support generics for parameters #2002

Merged
merged 7 commits into from Apr 20, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 17, 2022

🤔 What's changed?

  • Update the world documentation to cover worlds as plain functions
  • Update the world documentation to cover TypeScript stuff
  • Add support for generics for world parameters on world-related interfaces and classes

⚡️ What's your motivation?

Fixes #1968.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss added the 📖 documentation Improvements or additions to documentation label Apr 17, 2022
@coveralls
Copy link

coveralls commented Apr 17, 2022

Coverage Status

Coverage remained the same at 98.238% when pulling 9c8de6f on fix/docs-typescript-world-fn into c45330a on main.

@davidjgoss davidjgoss merged commit e60f503 into main Apr 20, 2022
@davidjgoss davidjgoss deleted the fix/docs-typescript-world-fn branch April 20, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: setWorldConstructor with anonymous function too restrictive
3 participants