Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(message-streams): defined direct dependency to satisfy gherkin-streams peer requirement for consumers #2006

Merged
merged 5 commits into from Apr 20, 2022

Conversation

travi
Copy link
Member

@travi travi commented Apr 20, 2022

closes #2005

🤔 What's changed?

defined direct dependency to satisfy gherkin-streams peer requirement for consumers

⚡️ What's your motivation?

fixes #2005

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 20, 2022

Coverage Status

Coverage remained the same at 98.238% when pulling 86d19dd on travi:message-streams into 7e1f858 on cucumber:main.

@travi
Copy link
Member Author

travi commented Apr 20, 2022

i see that dependency-lint is failing due to this change. i'm not familiar with that specific tool, but i disagree with its guidance in this case unless i'm overlooking something about this situation. i'm interested in feedback from the team about whether passing this unsatisfied peer requirement on to consumers is intentional in this case.

@davidjgoss davidjgoss self-requested a review April 20, 2022 20:13
@davidjgoss davidjgoss merged commit 103c599 into cucumber:main Apr 20, 2022
@aslakhellesoy
Copy link
Contributor

Hi @travi,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@travi travi deleted the message-streams branch April 20, 2022 20:37
@davidjgoss
Copy link
Contributor

Thanks @travi - released in v8.1.1 just now.

@travi
Copy link
Member Author

travi commented Apr 20, 2022

thanks a lot, @davidjgoss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peer dependency not fulfilled in latest release
4 participants