Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: record step keyword, deprecate defineStep #2044

Merged
merged 14 commits into from Jun 10, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 29, 2022

🤔 What's changed?

Rework our functions for defining steps - without changing the API or behaviour yet - so that we record the step keyword for Given, When and Then.

defineStep which allowed you to define a step without a keyword is now deprecated, and we'll remove it probably in 9.0.0 in a few months. In the meantime it records the step as a Given, which means we could progress with this feature before removing defineStep from the API if we want.

⚡️ What's your motivation?

First step in solving #2043 - we're recording the step keyword now, so later we'll be able to start using that to check against the pickle keyword when we introduce the stricter behaviour.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented May 29, 2022

Coverage Status

Coverage increased (+0.004%) to 98.297% when pulling 66621f6 on feat/record-step-keyword into 1e0831c on main.

@davidjgoss davidjgoss merged commit 73d8963 into main Jun 10, 2022
@davidjgoss davidjgoss deleted the feat/record-step-keyword branch June 10, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants