Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export IConfiguration interface for API users #2064

Merged
merged 3 commits into from Jun 21, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jun 21, 2022

🤔 What's changed?

Export IConfiguration on the API entry point.

⚡️ What's your motivation?

So API users can type the configuration objects they compose and pass in to the loadConfiguration function. I'm doing this now and it's painful without the typing.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Jun 21, 2022

Coverage Status

Coverage remained the same at 98.297% when pulling 4527494 on fix/export-configuration-interface into 0f5dab7 on main.

@davidjgoss davidjgoss merged commit 9877338 into main Jun 21, 2022
@davidjgoss davidjgoss deleted the fix/export-configuration-interface branch June 21, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants