Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default stderr if not provided to Cli ctor #2138

Merged
merged 2 commits into from
Sep 10, 2022
Merged

default stderr if not provided to Cli ctor #2138

merged 2 commits into from
Sep 10, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 10, 2022

🤔 What's changed?

In Cli, default the stderr property of the constructor object to process.stderr if it's not defined - making the property effectively optional for consumers.

⚡️ What's your motivation?

We introduced this property in #2137 which was effectively a breaking change for people who use the Cli class for framework integrations. It managed to fly under the radar until https://github.com/cucumber/cucumber-js/pull/2092/files#diff-7f71b0d311e14868f853f726912b222ac5e2aee58d985f1758d6b8f5e19c4c5c (8.5.2) where there'll be an error if it's missing. This affects nightwatch for example (see #2137).

This class will shortly be deprecated in favour of runCucumber et al, but in the meantime it should be stable.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title default stderr if not provided default stderr if not provided to Cli ctor Sep 10, 2022
@coveralls
Copy link

coveralls commented Sep 10, 2022

Coverage Status

Coverage remained the same at 98.236% when pulling bf8d9c8 on fix/cli-stderr into 01368ca on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants