Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include exceptions in test step result messages #2229

Merged
merged 13 commits into from
Feb 6, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Feb 4, 2023

🤔 What's changed?

  • Include exception in the result where there was an error in running a step.
  • Use that in the JUnit formatter for the <failure/> tag

⚡️ What's your motivation?

Confirm with latest CCK behaviour, get better parity with JVM's JUnit formatter

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Feb 4, 2023

Coverage Status

Coverage: 98.564% (+0.001%) from 98.563% when pulling 1fe8fcb on exceptions-in-messages into 88eb48d on main.

@davidjgoss davidjgoss marked this pull request as ready for review February 5, 2023 07:42
@davidjgoss davidjgoss merged commit 9779d26 into main Feb 6, 2023
@davidjgoss davidjgoss deleted the exceptions-in-messages branch February 6, 2023 12:54
@Rubea1435
Copy link

Can you please explain what's changed in this pull request? I use Cucumber.js since 8.0.0 version and there always have been error messages in step results with error trace.

@davidjgoss
Copy link
Contributor Author

@Rubea1435 you're right in that the information was there before. It's just now included in a more structured format that makes it more useful to certain reporting tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants