Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tone down global install warning #2285

Merged
merged 5 commits into from May 7, 2023
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 7, 2023

🤔 What's changed?

  • Tweak the wording of the global install warning to be less severe
  • Only do the check and warning if debug is enabled

⚡️ What's your motivation?

Fixes #2274 - since this can be a false positive, and the issues stemming from it are now much more obvious and actionable than they used to be, we don't need this to be prominent any more.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

Coverage Status

Coverage: 98.49% (+0.001%) from 98.489% when pulling 17bd819 on fix/tone-down-global-warning into 728fe26 on main.

@davidjgoss davidjgoss merged commit dc6ae91 into main May 7, 2023
10 checks passed
@davidjgoss davidjgoss deleted the fix/tone-down-global-warning branch May 7, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message when running cucumber test with npm prefix on Windows
2 participants