-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUnit Platform] Use EngineDiscoveryRequestResolver #2835
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
============================================
- Coverage 84.99% 84.86% -0.13%
+ Complexity 2733 2719 -14
============================================
Files 331 334 +3
Lines 9557 9569 +12
Branches 918 932 +14
============================================
- Hits 8123 8121 -2
- Misses 1109 1118 +9
- Partials 325 330 +5 ☔ View full report in Codecov by Sentry. |
29ff69e
to
bd9ac67
Compare
The current implementation of the JUnit Platform Engine treats Cucumbers documentation consistently uses This will become a problem if/when we start to use the |
🤔 What's changed?
⚡️ What's your motivation?
Fully utilize the
EngineDiscoveryRequestResolver
API to reduce our own complexity (junit-team/junit5#3705, junit-team/junit5#3718)🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist: