Nested steps should query over the wire too

[mattwynne]

This turns #1 into a failing test.

It seems like when we use a nested step, the mechanism for making that dynamic query for step defs does not query over the wire.

This is a symptom of the complexity around nested steps, and not necessarily something we want to prioritise fixing.

[aurelien-reeves]

Copied from #1 (comment):

It seems nested steps are suggest to discussion: cucumber/cucumber-ruby#1362

Maybe not supporting this in wire is not that bad?

[aurelien-reeves]

Actually it seems to work well as long as the nested step actually exist on the wire server

Did I miss something @mattwynne?

[mattwynne]

I've updated the feature file to hopefully clarify the problem being outlined.

Notice how the Given a step over the wire step passes when run from the feature file, but when you run the same step from Ruby step "a step over the wire" it fails with Undefined dynamic step. This is because Cucumber does not respect the "plugin" architecture for step definitions that we use here when searching for dynamic/nested steps.

[luke-hill]

@mattwynne maybe now I'm back a bit more we want to start deprecating / removing the ability for people to create dynamic steps?

[mattwynne]

Rather than removing nested steps altogether, I'd be in favour of re-architecting things so that they can be offered as a plugin. I know a lot of people use them, so I think it would be annoying to remove the behaviour altogether, but making it opt-in would communicate more clearly to novices what we consider to be good practice.

I also think it would probably be healthy for Cucumber's internals if we were able to decouple the code around this stuff enough that it could be offered through and extension point. Right now that's some of the most ancient code in the whole Cucumber org, and it could probably benefit from some love.