Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mime-types gem with mini_mime #1695

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

orien
Copy link
Contributor

@orien orien commented Jan 6, 2023

Description

mini_mime is a minimal mime type library that's more performant and uses less memory than the mime-types gem.

It has replaced mime-types in several projects:

Using it as a dependency of cucumber, downstream projects would be able to reuse the same dependency that is already available in most Rails apps, instead of pulling in an extra mime-types dependency.

Type of change

  • Refactoring (of dependencies) (improvements to code design or tooling that don't change behaviour)

Checklist

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@orien orien marked this pull request as ready for review January 6, 2023 16:55
@luke-hill
Copy link
Contributor

I will get to this. Sorry for delays. Just starting a new job and still configuring all my emails / IDE's e.t.c.

cucumber.gemspec Outdated Show resolved Hide resolved
@luke-hill luke-hill merged commit 85064d6 into cucumber:main Jan 11, 2023
@orien orien deleted the mini_mime branch January 11, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants