Skip to content

Commit

Permalink
Fix Georgian localization (#44)
Browse files Browse the repository at this point in the history
In cucumber/common#2041 only half a unicode glyph was
pasted to create `Მოცემულია `. This half glyph breaks code generation in other
projects, e.g:

https://github.com/cucumber/cucumber-jvm/actions/runs/3429109517/jobs/5714282373

This presumably (based on some searching) should have been `მოცემულია`. Though
I don't speak Georgian. Please send another pull request if this is not
correct.
  • Loading branch information
mpkorstanje committed Nov 9, 2022
1 parent 32089e3 commit 7d9d131
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 15 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ This document is formatted according to the principles of [Keep A CHANGELOG](htt

## [Unreleased]

### Fixed
- Fix half-glyph in Georgian translations ([#44](https://github.com/cucumber/gherkin/pull/44))

## [25.0.1] - 2022-11-09
### Fixed
- Fix release process for perl and elixir
Expand Down
8 changes: 4 additions & 4 deletions c/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ acceptance: .compared ## Build acceptance test dir and compare results with refe
.compared: .built $(TOKENS) $(ASTS) $(PICKLES) $(ERRORS) $(SOURCES) .run
touch $@

generate: ./include/rule_type.h src/parser.c src/dialect.c ## Generate gherkin parser files
generate: ./include/rule_type.h src/parser.c ## Generate gherkin parser files

clean-generate: ## Remove generated Gherkin parser files ## Generate gherkin parser files
rm -f ./include/rule_type.h src/parser.c src/dialect.c
rm -f ./include/rule_type.h src/parser.c
.PHONY: clean-generate

copy-gherkin-languages: ## Copy gherkin-languages.json and/or generate derived files
copy-gherkin-languages: src/dialect.c ## Copy gherkin-languages.json and/or generate derived files
echo "Nothing to do"

clean-gherkin-languages: ## Remove gherkin-languages.json and any derived files
echo "Nothing to do"
rm -f src/dialect.c

.built: generate $(SRC_FILES) src/Makefile
$(CC) --version
Expand Down
2 changes: 1 addition & 1 deletion c/src/dialect.c
Original file line number Diff line number Diff line change
Expand Up @@ -1989,7 +1989,7 @@ static const Keywords ka_examples_keywords = { 1, ka_examples_KEYWORDS };
static const wchar_t* const ka_feature_KEYWORDS[] = { L"თვისება", L"მოთხოვნა" };
static const Keywords ka_feature_keywords = { 2, ka_feature_KEYWORDS };

static const wchar_t* const ka_given_KEYWORDS[] = { L"* ", L"მოცემული ", L"Მოცემულია ", L"ვთქვათ " };
static const wchar_t* const ka_given_KEYWORDS[] = { L"* ", L"მოცემული ", L"მოცემულია ", L"ვთქვათ " };
static const Keywords ka_given_keywords = { 4, ka_given_KEYWORDS };

static const wchar_t* const ka_rule_KEYWORDS[] = { L"წესი" };
Expand Down
2 changes: 1 addition & 1 deletion dart/assets/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion dotnet/Gherkin/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion elixir/priv/gherkin_languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
4 changes: 2 additions & 2 deletions go/dialects_builtin.go
Original file line number Diff line number Diff line change
Expand Up @@ -2784,7 +2784,7 @@ var builtinDialects = gherkinDialectMap{
given: {
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ ",
},
when: {
Expand Down Expand Up @@ -2812,7 +2812,7 @@ var builtinDialects = gherkinDialectMap{
map[string]messages.StepKeywordType{
"მოცემული ": messages.StepKeywordType_CONTEXT,

"Მოცემულია ": messages.StepKeywordType_CONTEXT,
"მოცემულია ": messages.StepKeywordType_CONTEXT,

"ვთქვათ ": messages.StepKeywordType_CONTEXT,

Expand Down
2 changes: 1 addition & 1 deletion javascript/src/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion php/resources/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion python/gherkin/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down
2 changes: 1 addition & 1 deletion ruby/lib/gherkin/gherkin-languages.json
Original file line number Diff line number Diff line change
Expand Up @@ -2005,7 +2005,7 @@
"given": [
"* ",
"მოცემული ",
"Მოცემულია ",
"მოცემულია ",
"ვთქვათ "
],
"name": "Georgian",
Expand Down

0 comments on commit 7d9d131

Please sign in to comment.