-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case for extra table content #245
Draft
mpkorstanje
wants to merge
9
commits into
main
Choose a base branch
from
test-extra-table-content
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1959b0d
Test extra table content
mpkorstanje aa19f2f
Fix test data
mpkorstanje 40a1600
Dedicated test case
mpkorstanje 5ec2551
Try some fixes
mpkorstanje 9d13b34
Fix compile
mpkorstanje a911caa
Fix compile
mpkorstanje a659bd6
Fix compile
mpkorstanje 79b09fe
Fix compile
mpkorstanje 662a636
Fix compile
mpkorstanje File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Feature: Extra table content | ||
Tables are delimited by pipes on both sides. | ||
Anything that isn't enclosed is not part of | ||
the table. | ||
|
||
It is not recommended to use this feature, but | ||
it is how the implementation currently works. | ||
|
||
Scenario: We're a bit extra | ||
Given a pirate crew | ||
| Luffy | Zorro | Doflamingo \ | ||
| Nami | Brook | BlackBeard |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"gherkinDocument": {"comments": [], "feature": {"children": [{"scenario": {"description": "", "examples": [], "id": "3", "keyword": "Scenario", "location": {"column": 3, "line": 9}, "name": "We're a bit extra", "steps": [{"dataTable": {"location": {"column": 7, "line": 11}, "rows": [{"cells": [{"location": {"column": 9, "line": 11}, "value": "Luffy"}, {"location": {"column": 17, "line": 11}, "value": "Zorro"}], "id": "0", "location": {"column": 7, "line": 11}}, {"cells": [{"location": {"column": 9, "line": 12}, "value": "Nami"}, {"location": {"column": 17, "line": 12}, "value": "Brook"}], "id": "1", "location": {"column": 7, "line": 12}}]}, "id": "2", "keyword": "Given ", "keywordType": "Context", "location": {"column": 5, "line": 10}, "text": "a pirate crew"}], "tags": []}}], "description": " Tables are delimited by pipes on both sides.\n Anything that isn't enclosed is not part of\n the table.\n\n It is not recommended to use this feature, but\n it is how the implementation currently works.", "keyword": "Feature", "language": "en", "location": {"column": 1, "line": 1}, "name": "Extra table content", "tags": []}, "uri": "../testdata/good/extra_table_content.feature"}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"pickle": {"astNodeIds": ["3"], "id": "5", "language": "en", "name": "We're a bit extra", "steps": [{"argument": {"dataTable": {"rows": [{"cells": [{"value": "Luffy"}, {"value": "Zorro"}]}, {"cells": [{"value": "Nami"}, {"value": "Brook"}]}]}}, "astNodeIds": ["2"], "id": "4", "text": "a pirate crew", "type": "Context"}], "tags": [], "uri": "../testdata/good/extra_table_content.feature"}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"source": {"data": "Feature: Extra table content\n Tables are delimited by pipes on both sides.\n Anything that isn't enclosed is not part of\n the table.\n\n It is not recommended to use this feature, but\n it is how the implementation currently works.\n\n Scenario: We're a bit extra\n Given a pirate crew\n | Luffy | Zorro | Doflamingo \\\n | Nami | Brook | BlackBeard\n", "mediaType": "text/x.cucumber.gherkin+plain", "uri": "../testdata/good/extra_table_content.feature"}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
(1:1)FeatureLine:()Feature/Extra table content/ | ||
(2:1)Other:/ Tables are delimited by pipes on both sides./ | ||
(3:1)Other:/ Anything that isn't enclosed is not part of/ | ||
(4:1)Other:/ the table./ | ||
(5:1)Other:// | ||
(6:1)Other:/ It is not recommended to use this feature, but/ | ||
(7:1)Other:/ it is how the implementation currently works./ | ||
(8:1)Other:// | ||
(9:3)ScenarioLine:()Scenario/We're a bit extra/ | ||
(10:5)StepLine:(Context)Given /a pirate crew/ | ||
(11:7)TableRow://9:Luffy,17:Zorro | ||
(12:7)TableRow://9:Nami,17:Brook | ||
EOF |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the slash, maybe in another test case?