Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cpp): handle download failures and don't use GitHub api to get latest releases #247

Merged
merged 3 commits into from Apr 16, 2024
Merged

fix(cpp): handle download failures and don't use GitHub api to get latest releases #247

merged 3 commits into from Apr 16, 2024

Conversation

chybz
Copy link
Contributor

@chybz chybz commented Apr 14, 2024

🤔 What's changed?

  • Added build code to handle failures while downloading tools and/or dependencies

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

@chybz chybz self-assigned this Apr 14, 2024
@chybz chybz marked this pull request as ready for review April 14, 2024 10:31
@chybz chybz requested a review from kieran-ryan April 14, 2024 10:31
kieran-ryan
kieran-ryan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Sponsor Member

@kieran-ryan kieran-ryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @chybz, fair play - thanks for the swift fix!

@chybz chybz merged commit fe5b4c7 into main Apr 16, 2024
5 checks passed
@chybz chybz deleted the chybz/fix-ninja-download branch April 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieran-ryan kieran-ryan kieran-ryan approved these changes

Assignees

@chybz chybz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent failure of cpp test jobs in CI
2 participants
@chybz @kieran-ryan