feat: add stackTrace prop to Exception message #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
requested review from
mattwynne,
ciaranmcnulty,
brasmusson,
ehuelsmann,
mpkorstanje and
luke-hill
davidjgoss
commented
Nov 10, 2023
luke-hill
approved these changes
Nov 10, 2023
ehuelsmann
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Adds an optional
stackTraceprop to theExceptionmessage schema, so implementations have the ability to include the message and stack trace separately.⚡️ What's your motivation?
See cucumber/cucumber-js#2348 (comment)
Closes #70 (there is still a separate issue for adding “expected” and “actual” fields).
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.