go: do not change module name #89
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go modules are not only used externally, they are used internally as well. This means that when changed in a release they effectively break the released package. It is not feasible to change all module names with a script, and generally runs against the preferences of the go community. Unfortunately this does mean that we'll have to keep an eye out for breaking changes and change the module name accordingly.
mpkorstanje
force-pushed
the
go-do-not-change-module-name
branch
from
5e5ce31
to
4b6e520
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Go modules are not only used externally, they are used internally as well. This means that when changed in a release they effectively break the released package.
It is not feasible to change all module names with a script, and generally runs against the preferences of the go community. Unfortunately this does mean that we'll have to keep an eye out for breaking changes and change the module name accordingly.
This partially reverts #86
🏷️ What kind of change is this?
📋 Checklist: