Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render hook names if present #137

Merged
merged 5 commits into from
Apr 12, 2022
Merged

render hook names if present #137

merged 5 commits into from
Apr 12, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 11, 2022

🤔 What's changed?

Show the name of a hook (if it has one) when rendering a failed hook.

image

⚡️ What's your motivation?

Part of cucumber/messages#73.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Feat/named hooks render hook names if present Apr 11, 2022
@davidjgoss
Copy link
Contributor Author

We've ended up with multiple versions of messages:

cucumber-react % npm why @cucumber/messages
@cucumber/messages@17.1.1 dev
node_modules/@cucumber/create-meta/node_modules/@cucumber/messages
  @cucumber/messages@"^17.1.1" from @cucumber/create-meta@6.0.4
  node_modules/@cucumber/create-meta
    @cucumber/create-meta@"^6.0.1" from @cucumber/fake-cucumber@15.0.0
    node_modules/@cucumber/fake-cucumber
      dev @cucumber/fake-cucumber@"^15.0.0" from the root project

@cucumber/messages@17.1.1 dev
node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/messages
  @cucumber/messages@"^17.1.1" from @cucumber/fake-cucumber@15.0.0
  node_modules/@cucumber/fake-cucumber
    dev @cucumber/fake-cucumber@"^15.0.0" from the root project
  @cucumber/messages@"^17.1.1" from @cucumber/gherkin@22.0.0
  node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin
    @cucumber/gherkin@"^22.0.0" from @cucumber/fake-cucumber@15.0.0
    node_modules/@cucumber/fake-cucumber
      dev @cucumber/fake-cucumber@"^15.0.0" from the root project
  @cucumber/messages@"^17.1.0" from @cucumber/gherkin-streams@4.0.0
  node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams
    @cucumber/gherkin-streams@"^4.0.0" from @cucumber/fake-cucumber@15.0.0
    node_modules/@cucumber/fake-cucumber
      dev @cucumber/fake-cucumber@"^15.0.0" from the root project
  @cucumber/messages@"^17.1.0" from @cucumber/gherkin@21.0.0
  node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams/node_modules/@cucumber/gherkin
    @cucumber/gherkin@"^21.0.0" from @cucumber/gherkin-streams@4.0.0
    node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams
      @cucumber/gherkin-streams@"^4.0.0" from @cucumber/fake-cucumber@15.0.0
      node_modules/@cucumber/fake-cucumber
        dev @cucumber/fake-cucumber@"^15.0.0" from the root project
  @cucumber/messages@"^17.0.0" from @cucumber/message-streams@3.0.0
  node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/message-streams
    @cucumber/message-streams@"^3.0.0" from @cucumber/fake-cucumber@15.0.0
    node_modules/@cucumber/fake-cucumber
      dev @cucumber/fake-cucumber@"^15.0.0" from the root project
    @cucumber/message-streams@"^3.0.0" from @cucumber/gherkin@22.0.0
    node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin
      @cucumber/gherkin@"^22.0.0" from @cucumber/fake-cucumber@15.0.0
      node_modules/@cucumber/fake-cucumber
        dev @cucumber/fake-cucumber@"^15.0.0" from the root project
    @cucumber/message-streams@"^3.0.0" from @cucumber/gherkin-streams@4.0.0
    node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams
      @cucumber/gherkin-streams@"^4.0.0" from @cucumber/fake-cucumber@15.0.0
      node_modules/@cucumber/fake-cucumber
        dev @cucumber/fake-cucumber@"^15.0.0" from the root project
    @cucumber/message-streams@"^3.0.0" from @cucumber/gherkin@21.0.0
    node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams/node_modules/@cucumber/gherkin
      @cucumber/gherkin@"^21.0.0" from @cucumber/gherkin-streams@4.0.0
      node_modules/@cucumber/fake-cucumber/node_modules/@cucumber/gherkin-streams
        @cucumber/gherkin-streams@"^4.0.0" from @cucumber/fake-cucumber@15.0.0
        node_modules/@cucumber/fake-cucumber
          dev @cucumber/fake-cucumber@"^15.0.0" from the root project

@cucumber/messages@17.1.1
node_modules/@cucumber/gherkin-utils/node_modules/@cucumber/messages
  @cucumber/messages@"^17.1.0" from @cucumber/gherkin-utils@7.0.0
  node_modules/@cucumber/gherkin-utils
    @cucumber/gherkin-utils@"^7.0.0" from the root project
    @cucumber/gherkin-utils@"^7.0.0" from @cucumber/fake-cucumber@15.0.0
    node_modules/@cucumber/fake-cucumber
      dev @cucumber/fake-cucumber@"^15.0.0" from the root project

@cucumber/messages@18.0.0
node_modules/@cucumber/messages
  @cucumber/messages@"^18.0.0" from the root project
  peer @cucumber/messages@">=17.1.1" from @cucumber/message-streams@4.0.1
  node_modules/@cucumber/compatibility-kit/node_modules/@cucumber/message-streams
    @cucumber/message-streams@"^4.0.1" from @cucumber/compatibility-kit@9.2.0
    node_modules/@cucumber/compatibility-kit
      dev @cucumber/compatibility-kit@"^9.2.0" from the root project
  @cucumber/messages@"^18.0.0" from @cucumber/gherkin@23.0.1
  node_modules/@cucumber/gherkin
    dev @cucumber/gherkin@"^23.0.1" from the root project
    peer @cucumber/gherkin@">=22.0.0" from @cucumber/gherkin-streams@5.0.1
    node_modules/@cucumber/gherkin-streams
      dev @cucumber/gherkin-streams@"^5.0.1" from the root project
  peer @cucumber/messages@">=17.1.1" from @cucumber/gherkin-streams@5.0.1
  node_modules/@cucumber/gherkin-streams
    dev @cucumber/gherkin-streams@"^5.0.1" from the root project
  peer @cucumber/messages@">=17.1.1" from @cucumber/message-streams@4.0.1
  node_modules/@cucumber/message-streams
    dev @cucumber/message-streams@"^4.0.1" from the root project
    peer @cucumber/message-streams@">=4.0.0" from @cucumber/gherkin-streams@5.0.1
    node_modules/@cucumber/gherkin-streams
      dev @cucumber/gherkin-streams@"^5.0.1" from the root project

@cucumber/messages@17.1.1
node_modules/@cucumber/query/node_modules/@cucumber/messages
  @cucumber/messages@"^17.0.0" from @cucumber/query@11.0.0
  node_modules/@cucumber/query
    @cucumber/query@"^11.0.0" from the root project

I'll put an overrides in for now but we'll need to resolve this.

@davidjgoss davidjgoss marked this pull request as ready for review April 11, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants