Package JWK: if missing kid in jwks, then refresh JWKS #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed error on Debug() Info() etc. * removed unused func GetEnvBool * now can create logger with start up properties and use extensions * removed FromContext wip * removed nolint errcheck on ld client * added Child to Logger interface * example using Child to inherit parent values * added context helpers - unit tests still to come * started tests for context helpers * cleaned up tests and examples and made default fields appears inside properties * put default/global properties in a 'default_properties' sub-doc so they don't overwrite normal properties * updated README with logging examples
* updated to go 1.22.3 to close CVE-2024-24787 and CVE-2024-24788 * small update to the README to force snyk to pass the build * Trigger Build
* minor updates to linters * enabled all new linters by default and exclude only those we don't (yet) support * added internal revive linter fixes - no breaking changes * turned on ireturn linter * reemoved ex exclude rule in favour of //nolint * fixed some magic number lint errors * fixed conflict and golint ireturns * fixed all magic number lint warnings
* minor updates to linters * enabled all new linters by default and exclude only those we don't (yet) support * added internal revive linter fixes - no breaking changes * turned on ireturn linter * reemoved ex exclude rule in favour of //nolint * fixed some magic number lint errors * fixed conflict and golint ireturns * fixed all magic number lint warnings
|
AndrewMcCraeCA
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
To make key rotation & updates more automatic, if a kid is missing from the JWKS, then refresh the JWKS. This is all internal to the JWT package. No external changes required.
Changes: