Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LinkStyle): add LinkStyle component #4383

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Dec 1, 2023

What

Add LinkStyle component, which follows this proposed pattern https://cultureamp.atlassian.net/wiki/spaces/DesignSystem/pages/2993324684/Improve+Kaizen+Button+and+Link+components+-+Solution+Preview

Note: Design review required, as there aren't proper designs in our UI Kit, and after briefly showing Winter and Doug, we made up some accessible styles (accessibility requires that the underline always be shown).

Default Reversed
image image

Why

P &L fun time! KDS-2001
But also because we don't have one, and every team makes their own Link component, which isn't great.

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: f6d0a2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@HeartSquared HeartSquared marked this pull request as ready for review December 1, 2023 04:57
@HeartSquared HeartSquared requested a review from a team as a code owner December 1, 2023 04:57
Copy link
Contributor

github-actions bot commented Dec 1, 2023

✨ Here is your branch preview! ✨

Last updated for commit f6d0a2b: fix(LinkStyle): update reversed focus ring color

@HeartSquared HeartSquared marked this pull request as draft December 1, 2023 05:05
@HeartSquared HeartSquared marked this pull request as ready for review December 1, 2023 06:26
@HeartSquared HeartSquared marked this pull request as draft December 3, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant