Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency svgo to ^3.3.2 #4677

Merged
merged 3 commits into from
May 21, 2024

Conversation

cultureamp-renovate[bot]
Copy link
Contributor

@cultureamp-renovate cultureamp-renovate bot commented May 12, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
svgo (source) ^3.2.0 -> ^3.3.2 age adoption passing confidence

Release Notes

svg/svgo (svgo)

v3.3.2

Compare Source

Notice

An update on what happened with v3.3.0 and v3.3.1. While we have retained CJS support, the migration to EMS has changed the acceptable ways to import SVGO, in ways that users depended on before. This effectively made SVGO v3 a breaking change.

Rather than resolve or workaround these differences, we've opted to release SVGO v3.3.2, which is effectively a revert to v3.2.0, and deprecate versions v3.3.0 and v3.3.1. We'll then proceed to work on releasing v4 which will document the breaking changes, and feature further breaking changes that were slated for v4, like disabling removeViewBox by default.

Before the v4.0.0 release, I'll put more focus on testing and use release candidates, just to help make the release go smoothly! 👍🏽

Sorry for the headache, and thanks for your patience.

v3.3.1

Compare Source

Notice

SVGO v3.3.0, which was meant to migrate to ESM without breaking CJS support, unfortunately broke CJS projects. There was a mistake with exports, so the loadConfig function wasn't available in the CJS bundle and lead to issues for many users.

Thanks to everyone who raised the issue, and to @​nuintun who submitted a pull request to resolve it so quickly.

I apologize for letting that breaking change through, and will aim to do better. Namely, by adding more tests to cover our exports, and any other public interface in general for each distribution of SVGO, so this doesn't happen again.

SVGO v3.3.1 should resolve the issue for CJS projects, but if you encounter anything else, do let us know by opening an issue on GitHub.

v3.3.0

Compare Source

Deprecated

This release introduced breaking changes, which have been reverted in v3.3.2. The bug fixes will be reintroduced in v4.0.0.

What's Changed

ESM

SVGO is now a dual package, serving for both Common JS and ESM usage. We believe there shouldn't be any problems, especially as SVGO as largely stateless, but feel free to open an issue if you encounter problems with this.

To be explicit, this is not a breaking change, and SVGO should continue to work in Common JS projects!

Thanks to @​jdufresne for doing the bulk of the work.

Default Behavior
  • convertColors, now converts all references to colors excluding references to IDs to lowercase. This can be disabled by setting convertCase to false.
Bug Fixes
SVG Optimization

Metrics

Before and after using vectors from various sources, with the default preset of each respective version:

SVG Original v3.2.0 v3.3.0 Delta
Arch Linux Logo 9.529 KiB 4.115 KiB 4.097 KiB ⬇️ 0.018 KiB
Blobs 50.45 KiB 42.623 KiB 42.609 KiB ⬇️ 0.014 KiB
Isometric Madness 869.034 KiB 540.582 KiB 540.073 KiB ⬇️ 0.509 KiB
tldr-pages Banner 2.071 KiB 1.07 KiB 1.07 KiB
Wikipedia Logo 161.551 KiB 111.668 KiB 111.668 KiB

Before and after of the browser bundle of each respective version:

v3.2.0 v3.3.0 Delta
svgo.browser.js 910.9 kB 753.0 kB ⬇️ 157.9 kB

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@cultureamp-renovate
Copy link
Contributor Author

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.


  • Branch has one or more failed status checks

Copy link

changeset-bot bot commented May 12, 2024

🦋 Changeset detected

Latest commit: 969c462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gyfchong gyfchong marked this pull request as ready for review May 20, 2024 23:37
@gyfchong gyfchong requested a review from a team as a code owner May 20, 2024 23:37
Copy link
Contributor

github-actions bot commented May 20, 2024

✨ Here is your branch preview! ✨

Last updated for commit 969c462: Merge branch 'renovate/rollup' into renovate/update/svgo-3.x

@gyfchong gyfchong merged commit 0b20f70 into renovate/rollup May 21, 2024
17 checks passed
@gyfchong gyfchong deleted the renovate/update/svgo-3.x branch May 21, 2024 01:37
cultureamp-renovate bot added a commit that referenced this pull request May 22, 2024
* chore(deps): update dependency @storybook/theming to ^8.0.10

* chore(deps): update dependency @tanstack/react-query to ^5.35.5

* chore(deps): update dependency @testing-library/react to ^15.0.7

* chore(deps): update dependency chromatic to ^11.3.2

* chore(deps): update dependency playwright to ^1.44.0

* chore(deps): update dependency rimraf to ^5.0.6

* chore(deps): update dependency @types/react to ^18.3.2

* chore(deps): update dependency turbo to ^1.13.3

* chore(deps): update dependency @storybook/test-runner to ^0.18.0

* chore(deps): update dependency @types/node to ^20.12.11

* chore(deps): update dependency rimraf to ^5.0.7

* chore(deps): update dependency sass-loader to ^14.2.1

* chore(deps): update dependency @tanstack/react-query to ^5.36.0

* chore(deps): update dependency tocbot to ^4.27.20

* chore(deps): update dependency @changesets/cli to ^2.27.2

* chore(deps): update dependency @storybook/test-runner to ^0.18.1

* chore(deps): update dependency @tanstack/react-query to ^5.36.2

* chore(deps): update dependency @types/node to ^20.12.12

* chore(deps): update dependency chromatic to ^11.3.5

* chore(deps): update dependency rollup-plugin-dts to ^6.1.1

* chore(deps): update dependency sass to ^1.77.2 (#4672)

* chore(deps): update dependency sass to ^1.77.2

* add changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update dependency @floating-ui/react-dom to ^2.0.9 (#4673)

* fix(deps): update dependency @floating-ui/react-dom to ^2.0.9

* add changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update dependency react-day-picker to ^8.10.1 (#4674)

* fix(deps): update dependency react-day-picker to ^8.10.1

* add changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update dependency react-focus-on to ^3.9.3 (#4675)

* fix(deps): update dependency react-focus-on to ^3.9.3

* add changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* chore(deps): update dependency @tanstack/react-query to ^5.37.1 (#4685)

* chore(deps): update dependency @tanstack/react-query to ^5.37.1

* added boilerplate

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update dependency react-intl to ^6.6.8 (#4684)

* fix(deps): update dependency react-intl to ^6.6.8

* add empty changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* chore(deps): update storybook monorepo to ^8.1.1 (#4687)

* chore(deps): update storybook monorepo to ^8.1.1

* add empty changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>
Co-authored-by: Geoffrey Chong <gyfchong@users.noreply.github.com>

* chore(deps): update dependency svgo to ^3.3.2 (#4677)

* chore(deps): update dependency svgo to ^3.3.2

* add empty changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* chore(deps): update dependency storybook-addon-pseudo-states to v3 (#4691)

* update storybook-addon-pseudo-states to v3

* add empty changeset

* fix wrong storybook version

* fix wrong storybook version

* chore(deps): update eslint dependencies to ^7.9.0 (#4686)

* chore(deps): update eslint dependencies to ^7.9.0

* add changeset

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update dependency react-focus-lock to ^2.12.1 (#4689)

* fix(deps): update dependency react-focus-lock to ^2.12.1

* update pnpm lock

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyfchong@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* fix(deps): update prosemirror (#4690)

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>

* remove rollup

* chore(deps): update dependency style-loader to v4 (#4688)

* chore(deps): update dependency style-loader to v4

* add changeset

* fix pnpm lock

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>
Co-authored-by: Geoffrey Chong <gyfchong@users.noreply.github.com>

* Update warm-roses-play.md

* Update sixty-rabbits-develop.md

* pnpm lock

* Update sixty-rabbits-develop.md

---------

Co-authored-by: Self-hosted Renovate Bot <135776+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: cultureamp-renovate[bot] <89962466+cultureamp-renovate[bot]@users.noreply.github.com>
Co-authored-by: Geoffrey Chong <gyf.chong@gmail.com>
Co-authored-by: Geoffrey Chong <gyfchong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant