Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing UpdateH5 logic in Sdk.targets #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mjrist
Copy link
Contributor

@mjrist mjrist commented Jul 11, 2023

It was not possible to set UpdateH5 to false to disable the update of the global h5 compiler when not using the compilation server.

This change updates the checks to make this possible.

Summary of the updated behavior:

If using the global compiler and it is not installed, UpdateH5 gets set to true so that it gets installed. (Now this simply calls h5 instead of h5 check-if-online which would return non-zero if the server was not running even though h5 was installed.)

If using the global compiler and it is installed, then do whatever is indicated by UpdateH5.

  • UpdateH5 is set to true by default to keep the existing behavior of checking for updates when using the global tool (w/o the compilation server).
  • Can now set this to false to disable updates of the global h5 compiler.

If using the local compiler always set UpdateH5 to false - never update or install.

@mjrist
Copy link
Contributor Author

mjrist commented Jul 14, 2023

@theolivenbaum any thoughts on this change? I'm open to suggestions. I've tested this out and it works great for us. We would love to see this merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant