fix: review newly added rules in typescript-eslint

BREAKING CHANGE: enable new rules in typescript-eslint/recommended
cybozu · May 25, 2020 · c34ccaf · c34ccaf
1 parent cd3e419
commit c34ccaf
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/lib/typescript.js b/lib/typescript.js
@@ -1,10 +1,7 @@
 module.exports = {
   parser: "@typescript-eslint/parser",
   plugins: ["@typescript-eslint"],
-  extends: [
-    "plugin:@typescript-eslint/eslint-recommended",
-    "plugin:@typescript-eslint/recommended"
-  ],
+  extends: ["plugin:@typescript-eslint/recommended"],
   // It's 5〜10x slower with the project setting.
   // So We disable it until the issue has been fixed
   /*
@@ -17,15 +14,12 @@ module.exports = {
 
     "no-useless-constructor": "off",
     "@typescript-eslint/no-useless-constructor": "warn",
-    "@typescript-eslint/type-annotation-spacing": "warn",
     "@typescript-eslint/unified-signatures": "warn",
     "@typescript-eslint/indent": ["warn", 2, { SwitchCase: 1 }],
 
-    "@typescript-eslint/ban-ts-ignore": "off",
-    "@typescript-eslint/camelcase": "off",
-    "@typescript-eslint/explicit-function-return-type": "off",
+    "@typescript-eslint/ban-ts-comment": "off",
     "@typescript-eslint/explicit-member-accessibility": "off",
-    "@typescript-eslint/interface-name-prefix": "off",
+    "@typescript-eslint/explicit-module-boundary-types": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-empty-interface": "off",
     "@typescript-eslint/no-inferrable-types": "off",
@@ -34,7 +28,6 @@ module.exports = {
     "@typescript-eslint/no-object-literal-type-assertion": "off",
     "@typescript-eslint/no-triple-slash-reference": "off",
     "@typescript-eslint/no-unused-vars": "off",
-    "@typescript-eslint/no-use-before-define": "off",
     "@typescript-eslint/no-var-requires": "off",
     "@typescript-eslint/prefer-interface": "off",
     "@typescript-eslint/prefer-namespace-keyword": "off"